fix: use require instead of t.Fatal(err) in tests/e2e package#18821
fix: use require instead of t.Fatal(err) in tests/e2e package#18821ahrtr merged 1 commit intoetcd-io:mainfrom mmorel-35:tests/e2e/testifier/require-error
Conversation
|
Hi @mmorel-35. Thanks for your PR. I'm waiting for a etcd-io member to verify that this patch is reasonable to test. If it is, they should reply with Once the patch is verified, the new status will be reflected by the I understand the commands that are listed here. DetailsInstructions for interacting with me using PR comments are available here. If you have questions or suggestions related to my behavior, please file an issue against the kubernetes-sigs/prow repository. |
|
/assign @spzala |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted filessee 20 files with indirect coverage changes @@ Coverage Diff @@
## main #18821 +/- ##
==========================================
- Coverage 68.77% 68.71% -0.07%
==========================================
Files 420 420
Lines 35598 35598
==========================================
- Hits 24483 24461 -22
- Misses 9685 9709 +24
+ Partials 1430 1428 -2 Continue to review full report in Codecov by Sentry.
|
|
/assign @ahrtr |
|
/ok-to-test |
|
This PR is just mechanical changes, but we love small PRs. I will let this PR in, but please try to submit small PR , i.e. < 100 lines of code change as much as you can next time. Thanks. |
|
Question: do all of these changes come from this specific linter? There are some formatting changes that look unrelated, but I may be wrong. |
fuweid
left a comment
fuweid
left a comment
There was a problem hiding this comment.
Basically, it looks good.
The pull requests include refactors, for example,
- var =>
:= - Two lines => one line
- Adding empty line
For reviewer, if non-related change is small, it's easy to be accepted and review
However, there are too many lines changed not related to that using requires.
My suggestion is that if linter doesn't blame, just keep it as it is and file other pull request for that.
|
The formatting shouldn't be part of this PR. I hold on this to apply gofumpt first |
|
/retest |
1 similar comment
|
/retest |
Signed-off-by: Matthieu MOREL <matthieu.morel35@gmail.com>
|
/retest |
1 similar comment
|
/retest |
|
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: ahrtr, fuweid, mmorel-35 The full list of commands accepted by this bot can be found here. The pull request process is described here DetailsNeeds approval from an approver in each of these files:
Approvers can indicate their approval by writing |
7 participants
Description
This uses testify instead of testing for t.Fatal calls
Related to #18972